justinpark opened a new pull request, #26699:
URL: https://github.com/apache/superset/pull/26699

   ### SUMMARY
   Following up #26313
   This commit addresses and resolves the issue of an unclear drop zone 
indicator that was negatively impacting the user experience in the dashboard 
editor. 
   
   When a component was being dragged towards the edge of the tab container or 
the row/column containers, multiple drop indicators were often displayed. This 
created confusion about the exact insertion point of the element. [fig. 1]
   
   |fig. 1|
   |--|
   
|![drop-indicator-bug](https://github.com/apache/superset/assets/1392866/b984aebb-2dd0-48bf-b49f-86e49e535e73)|
   
   The root of the problem was that these dashboard components were wrapped by 
both draggable and droppable interfaces, which led to overlapping and 
conflicting drop zones. This commit modifies this by making the dashboard 
components draggable only, and builds a distinct, non-conflicting area for the 
drop zone. Moreover, it also highlights the drop zone during the dragging 
process to clearly indicate where the element will be placed. [fig. 2]
   
   |fig. 1|
   |--|
   
|![drop-indicator-after](https://github.com/apache/superset/assets/1392866/b44760b4-1f5e-4241-8fa4-6d2f487185b0)|
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   
https://github.com/apache/superset/assets/1392866/315309e9-a8ad-45c4-a292-190a318c8d67
   
   After:
   
   
https://github.com/apache/superset/assets/1392866/2342eee1-418d-4c35-9a21-f5772136c0ec
   
   
   ### TESTING INSTRUCTIONS
   Go to dashboard and edit mode
   Drag and drag multiple components and then save
   Verify the dashboard shown as designed
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to