eschutho commented on code in PR #26327:
URL: https://github.com/apache/superset/pull/26327#discussion_r1446705907
##########
superset/reports/notifications/email.py:
##########
@@ -177,8 +177,7 @@ def _get_content(self) -> EmailContent:
def _get_subject(self) -> str:
return __(
- "%(prefix)s %(title)s",
- prefix=app.config["EMAIL_REPORTS_SUBJECT_PREFIX"],
Review Comment:
To keep backward compatibility, can we continue to include the prefix if
`app.config["EMAIL_REPORTS_SUBJECT_PREFIX"]` exists or is not
blank/empty/nullish? This way each application can decide for themselves if
they would like to include a prefix or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
