eschutho commented on code in PR #26327:
URL: https://github.com/apache/superset/pull/26327#discussion_r1460113155
##########
superset/reports/notifications/email.py:
##########
@@ -177,8 +177,7 @@ def _get_content(self) -> EmailContent:
def _get_subject(self) -> str:
return __(
- "%(prefix)s %(title)s",
- prefix=app.config["EMAIL_REPORTS_SUBJECT_PREFIX"],
Review Comment:
I agree with @giftig on the premise that the app.config is set by the
application admin, whereas the title will be set by individual users. If an
application admin set an app.config prefix, it's likely something important
that they don't want removed from the emails, such as "Company Confidential",
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
