puridach-w commented on code in PR #26327:
URL: https://github.com/apache/superset/pull/26327#discussion_r1461338005


##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -1160,6 +1167,18 @@ const AlertReportModal: 
FunctionComponent<AlertReportModalProps> = ({
     setIsHidden(false);
   }
 
+  const updateEmailSubject = () => {
+    if (contentType === 'chart') {
+      setEmailSubject(
+        `${currentAlert?.name}: ${currentAlert?.chart?.label || ''}`,
+      );
+    } else {
+      setEmailSubject(
+        `${currentAlert?.name}: ${currentAlert?.dashboard?.label || ''}`,
+      );
+    }

Review Comment:
   As you can see in the image the default value will be shown if user doesn't 
input any text and this code is a part of that function.
   
   
![image](https://github.com/apache/superset/assets/76474644/794d7cc7-b504-4db2-8d66-10da2e8fc274)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to