john-bodley commented on code in PR #26909:
URL: https://github.com/apache/superset/pull/26909#discussion_r1475177202
##########
tests/integration_tests/datasets/api_tests.py:
##########
@@ -1748,7 +1748,7 @@ def test_export_dataset(self):
assert rv.status_code == 200
cli_export = export_to_dict(
- session=db.session,
+ db.session.db.session,
Review Comment:
Ha! My sed search and replace definitely screwed up a few things, but I
thought I had addressed all of these given that CI was passing. Having `mypy`
and `pylint` checks enabled for our tests would definitely be beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
