john-bodley commented on code in PR #26909:
URL: https://github.com/apache/superset/pull/26909#discussion_r1475205305
##########
tests/unit_tests/tags/commands/update_test.py:
##########
@@ -30,7 +31,7 @@ def session_with_data(session: Session):
from superset.models.sql_lab import Query, SavedQuery
from superset.tags.models import Tag
- engine = session.get_bind()
+ engine = db.session.get_bind()
Review Comment:
See https://github.com/apache/superset/pull/26909#issuecomment-1922328534.
##########
tests/unit_tests/tags/commands/update_test.py:
##########
@@ -117,8 +120,8 @@ def test_update_command_success_duplicates(
from superset.models.slice import Slice
from superset.tags.models import ObjectType, TaggedObject
- dashboard = session_with_data.query(Dashboard).first()
- chart = session_with_data.query(Slice).first()
+ dashboard = db.session.query(Dashboard).first()
Review Comment:
See https://github.com/apache/superset/pull/26909#issuecomment-1922328534.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
