john-bodley commented on code in PR #26909:
URL: https://github.com/apache/superset/pull/26909#discussion_r1475356978
##########
tests/unit_tests/charts/dao/dao_tests.py:
##########
@@ -20,14 +20,15 @@
import pytest
from sqlalchemy.orm.session import Session
+from superset import db
from superset.utils.core import DatasourceType
@pytest.fixture
def session_with_data(session: Session) -> Iterator[Session]:
from superset.models.slice import Slice
- engine = session.get_bind()
+ engine = db.session.get_bind()
Review Comment:
@michael-s-molina I'll revert the logic so that all fixtures augment the
`session` fixture as opposed to `db.session`. Also I don't think these fixtures
behave as the author(s) originally intended in terms of how the records are
committed/rollbacked—though that's a headache for a different day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
