kgabryje commented on code in PR #27029:
URL: https://github.com/apache/superset/pull/27029#discussion_r1480074089
##########
superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx:
##########
@@ -90,12 +90,14 @@ const ChartContextMenu = (
const canExplore = useSelector((state: RootState) =>
findPermission('can_explore', 'Superset', state.user?.roles),
);
- const canViewDrill = useSelector((state: RootState) =>
- findPermission('can_view_and_drill', 'Dashboard', state.user?.roles),
+ const canWriteExploreFormData = useSelector((state: RootState) =>
+ findPermission('can_write', 'ExploreFormDataRestAPI', state.user?.roles),
);
const canDatasourceSamples = useSelector((state: RootState) =>
findPermission('can_samples', 'Datasource', state.user?.roles),
);
+ const canDrillBy = canExplore && canWriteExploreFormData;
Review Comment:
Wasn't it the point of the previous PR that a user could be granted an
access to drill by without can_explore permission?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
