geido commented on PR #27029: URL: https://github.com/apache/superset/pull/27029#issuecomment-1933701965
> Would this PR address or affect open issue #25630? > > It looks relevant to open issue #26762, at a glance it would not solve it (Gamma would still need `can_samples`) but if someone working on this PR felt in the right headspace to tackle this issue it would save on task switching costs. @sfirke in terms of fixing the mentioned issues, I think this PR should be the solution. Drill to detail must be tied to `can_samples` in order to function and `can_explore. Drill by requires `can_write` on `ExploreFormDataRestApi` or there will be an error message showing up when posting form data, together with `can_explore`. Haven't checked whether these permissions can work without `can_explore` but my objective here is to avoid a breaking change. The View as table and View query options now can be enabled granularly and the Edit chart buttons will be disabled if `can_explore` is OFF. As for what concerns assigning/changing permissions of the existing roles, this is beyond the scope of this PR and I think it would be best to discuss this opportunity in the appropriate channels. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
