mistercrunch commented on code in PR #27029:
URL: https://github.com/apache/superset/pull/27029#discussion_r1480297223
##########
superset/security/manager.py:
##########
@@ -726,7 +726,8 @@ def create_custom_permissions(self) -> None:
self.add_permission_view_menu("can_csv", "Superset")
self.add_permission_view_menu("can_share_dashboard", "Superset")
self.add_permission_view_menu("can_share_chart", "Superset")
- self.add_permission_view_menu("can_view_and_drill", "Dashboard")
Review Comment:
It'd be nice to have a reusable function for perm migration that we could
use in database migrations. Now that we have `migration_utils.py` in theory it
could contain a function `migrate_permission(before_perm, after_perm)`. Though
in theory it should only be use for equivalent (rename) or more
atomic/selective permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
