geido commented on code in PR #24449:
URL: https://github.com/apache/superset/pull/24449#discussion_r1502945531
##########
superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx:
##########
@@ -91,6 +100,49 @@ class RefreshIntervalModal extends React.PureComponent<
this.setState({
refreshFrequency: value || refreshIntervalOptions[0][0],
});
+
+ this.setState({
+ custom_block: value === -1,
+ });
+
+ if (value === -1) {
+ this.setState({
+ custom_hour: 0,
+ custom_min: 0,
+ custom_sec: 0,
+ });
+ }
+ }
+
+ onSaveValue(value: number) {
+ this.props.onChange(value, this.props.editMode);
+ this.modalRef?.current?.close();
+ this.props.addSuccessToast(t('Refresh interval saved'));
+ }
+
+ createIntervalOptions(refreshIntervalOptions: [number, string][]) {
+ const refresh_options = [];
+ if (!refreshIntervalOptions.length) {
+ refresh_options.push({ value: -1, label: 'Custom interval' });
Review Comment:
I think the label here need to be localized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
