geido commented on code in PR #24449:
URL: https://github.com/apache/superset/pull/24449#discussion_r1507886383
##########
superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx:
##########
@@ -91,6 +100,49 @@ class RefreshIntervalModal extends React.PureComponent<
this.setState({
refreshFrequency: value || refreshIntervalOptions[0][0],
});
+
+ this.setState({
+ custom_block: value === -1,
+ });
+
+ if (value === -1) {
+ this.setState({
+ custom_hour: 0,
+ custom_min: 0,
+ custom_sec: 0,
+ });
+ }
+ }
+
+ onSaveValue(value: number) {
+ this.props.onChange(value, this.props.editMode);
+ this.modalRef?.current?.close();
+ this.props.addSuccessToast(t('Refresh interval saved'));
+ }
+
+ createIntervalOptions(refreshIntervalOptions: [number, string][]) {
+ const refresh_options = [];
+ if (!refreshIntervalOptions.length) {
+ refresh_options.push({ value: -1, label: 'Custom interval' });
+ return refresh_options;
+ }
+
+ refresh_options.push({ value: -1, label: 'Custom interval' });
Review Comment:
What I mean is that you are duplicating the code by using the condition
`!refreshIntervalOptions.length` and then pushing the custom interval option,
but you also do the same when `refreshIntervalOptions.length` is larger than 0.
So just do:
```
refresh_options.push({ value: -1, label: 'Custom interval' });
if (refreshIntervalOptions.length) {
refresh_options.push(
...refreshIntervalOptions.map(option => ({
value: option[0],
label: t(option[1]),
})),
);
}
return refresh_options;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
