geido commented on code in PR #27439:
URL: https://github.com/apache/superset/pull/27439#discussion_r1518059867
##########
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx:
##########
@@ -256,10 +264,51 @@ export class Tabs extends React.PureComponent {
}
};
+ // the initial color map is generated on save and catches all rendered charts
Review Comment:
Currently the initial color map is stored in the dashboard metadata at save
but fails to map colors of charts that are hidden within tabs as those are not
rendered. This checks for new colors popping in the color map that are not
stored in metadata yet when a tab and its charts are rendered. It then updates
the metadata accordingly. The stored color map is then used by the viz in
Explore to respect the colors of the dashboard context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
