geido commented on PR #27439: URL: https://github.com/apache/superset/pull/27439#issuecomment-1986149464
> @geido would it be possible to add a brief description of the mechanics of the changes in this PR? This would help grasp the chosen approach without having to dive directly into the diff. @villebro this is meant to fix the regression introduced in https://github.com/apache/superset/pull/23762 so there is not much more context to add. However, I added inline comments to the parts of the code that I think introduce new behaviours or that might require clarifications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org