kgabryje commented on code in PR #27439:
URL: https://github.com/apache/superset/pull/27439#discussion_r1524964513
##########
superset-frontend/packages/superset-ui-core/src/color/CategoricalColorScale.ts:
##########
@@ -39,99 +38,172 @@ class CategoricalColorScale extends ExtensibleFunction {
scale: ScaleOrdinal<{ toString(): string }, string>;
- parentForcedColors: ColorsLookup;
-
forcedColors: ColorsLookup;
+ sharedColorMapInstance: ReturnType<typeof getSharedLabelColor>;
+
+ sliceMap: Map<string, string>;
Review Comment:
I'm assuming it's a mapping of series/dimensions and colours assigned to
them? If so, could we maybe change that name, since we're often calling saved
charts "slices", which could be confusing here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
