eschutho commented on code in PR #26391:
URL: https://github.com/apache/superset/pull/26391#discussion_r1548305032
##########
superset/sqllab/api.py:
##########
@@ -236,6 +240,7 @@ def format_sql(self) -> FlaskResponse:
return self.response_400(message=error.messages)
@expose("/export/<string:client_id>/")
Review Comment:
@jessie-ross Thanks for the great feature proposal. I was reading through
the SIP, and thought I might suggest another option here which would be to use
the existing api "/export/<string:client_id>/" and pass the export type with a
query string `?format=csv` for example. That could potentially simplify this.
It seems like the request/response schemas should be fairly similar, with just
a switch in the command that is run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
