jessie-ross commented on code in PR #26391:
URL: https://github.com/apache/superset/pull/26391#discussion_r1548916998
##########
superset/sqllab/api.py:
##########
@@ -236,6 +240,7 @@ def format_sql(self) -> FlaskResponse:
return self.response_400(message=error.messages)
@expose("/export/<string:client_id>/")
Review Comment:
I'm happy to go either way on the url format, the two are equivalent:
```
/export/<client-id>/?format=csv
/export/<client-id>/?format=google-sheets
/export/<client-id>/ (csv, deprecated)
```
```
/export/<client-id>/csv/
/export/<client-id>/google-sheets/
/export/<client-id>/ (csv, deprecated)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
