john-bodley commented on code in PR #27889:
URL: https://github.com/apache/superset/pull/27889#discussion_r1550679498
##########
superset/db_engine_specs/presto.py:
##########
@@ -1329,7 +1329,9 @@ def handle_cursor(cls, cursor: Cursor, query: Query) ->
None:
completed_splits,
total_splits,
)
- if progress > query.progress:
+ if ( # pylint: disable=consider-using-min-builtin
Review Comment:
I opted not to use the suggestion, i.e., `query.progress = max(progress,
query.progress)` as this would likely dirty the SQLAlchemy object and result in
an excess of commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
