john-bodley commented on PR #27889: URL: https://github.com/apache/superset/pull/27889#issuecomment-2035892857
@mistercrunch looking into the checks for https://github.com/apache/superset/pull/27867 it seems like the logic is wrong in terms of eligibility, i.e., the following jobs didn't run: - [pre-commit (3.9)](https://github.com/apache/superset/actions/runs/8533736544/job/23376904109) - [python-lint (3.9)](https://github.com/apache/superset/actions/runs/8533736544/job/23376904480) - [python-lint (3.10)](https://github.com/apache/superset/actions/runs/8533736544/job/23376904970) as well as all the Python unit and integration tests, because it perceived it to be a no-op step. Although these changes don't touch any Python files they have the potential to impact the entire Python code base and thus it seems imperative that _all_ Python checks are enabled before anymore `supersetbot` PRs related to bumping Python packages are merged. Additionally all currently opened `supersetbot` PRs which attempt to bump a Python package should be rebased once this issue has been remedied in order for the full CI suite to run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
