mistercrunch commented on PR #27889: URL: https://github.com/apache/superset/pull/27889#issuecomment-2037602842
I think the issue https://github.com/apache/superset/pull/27867 is that it didn't touch any files in `superset/**` (as specified here https://github.com/apache/superset/blob/master/.github/workflows/superset-python-misc.yml#L14) which means the "no-op" check took precedence over the skipped check, as expected. Now adding `requirements/**` to the line bellow the one I pointed to above might help, saying "if we change a python dep, run the python checks in this file". (I'll write a PR for this) About GHA checks, there are these core issues I'd like to address: - there's no "this check is required to succeed, but only if it's triggered" - the no-ops are a work around this issue - there's no "the whole matrix of checks need to succeed" semantics, meaning if you have a 4*3 matrix you need to spell out the 12 required checks... - there's no good mechanism to keep things DRY in actions (simply referencing a `global.main-python-version`) in multiple files isn't possible. There's the concept of reusable actions and workflows, but basic templating would go a long way. - the required checks source of truth are the ones specified in the main branch, which means deprecating a check can **only** be done through some sort of no-op, that then needs to get cleaned up once merge - secrets are sometimes available, sometimes not One more issue that has more to do on how we use GHA than its mechanics, is we have a bunch of single-item matrix (`python-version: ["3.10"]`), which created challenges around the issue above when migrating. For this I'm thinking de-matrixing things to simplify things a little, so the next python upgrade wouldn't mean creating a bunch of new no-ops. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
