rusackas commented on code in PR #28349:
URL: https://github.com/apache/superset/pull/28349#discussion_r1591597810
##########
superset-frontend/src/pages/SavedQueryList/index.tsx:
##########
@@ -443,7 +447,7 @@ function SavedQueryList({
const filters: Filters = useMemo(
() => [
{
- Header: t('Name'),
+ Header: t('search'),
Review Comment:
What's the impetus for this change? All the other list views say "Name"
since they only search the Name. Does this one also search descriptions?
Obviously it ought to be truthful, but otherwise I'd err on the side of
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
