nytai commented on code in PR #28349:
URL: https://github.com/apache/superset/pull/28349#discussion_r1590479993
##########
superset-frontend/src/pages/SavedQueryList/index.tsx:
##########
@@ -449,6 +453,12 @@ function SavedQueryList({
input: 'search',
operator: FilterOperator.AllText,
},
+ {
+ Header: t('Description'),
+ id: 'description',
+ key: 'description',
+ operator: FilterOperator.AllText,
Review Comment:
it's actually searching all text columns (name, description, sql, label), so
it can probably just be called "search"
https://github.com/apache/superset/blob/f5843fe588112c5c303215945a36fda0845c9e99/superset/queries/saved_queries/filters.py#L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
