michael-s-molina commented on code in PR #28597:
URL: https://github.com/apache/superset/pull/28597#discussion_r1608167463
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/types.ts:
##########
@@ -45,6 +45,7 @@ export type EchartsPieFormData = QueryFormData &
numberFormat: string;
dateFormat: string;
showLabelsThreshold: number;
+ roseType?: 'radius' | 'area';
Review Comment:
```suggestion
roseType: 'radius' | 'area' | null;
```
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/types.ts:
##########
@@ -78,6 +79,7 @@ export const DEFAULT_FORM_DATA: EchartsPieFormData = {
labelsOutside: true,
showLabelsThreshold: 5,
dateFormat: 'smart_date',
+ roseType: undefined,
Review Comment:
```suggestion
roseType: null,
```
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx:
##########
@@ -87,6 +88,23 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'roseType',
+ config: {
+ type: 'SelectControl',
+ label: t('Rose Type'),
+ default: roseType,
+ renderTrigger: true,
+ choices: [
+ ['area', t('Area')],
+ ['radius', t('Radius')],
+ [false, t('None')],
Review Comment:
```suggestion
[null, t('None')],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
