michael-s-molina commented on code in PR #28597:
URL: https://github.com/apache/superset/pull/28597#discussion_r1608339207
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx:
##########
@@ -87,6 +88,23 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'roseType',
+ config: {
+ type: 'SelectControl',
+ label: t('Rose Type'),
+ default: roseType,
+ renderTrigger: true,
+ choices: [
+ ['area', t('Area')],
+ ['radius', t('Radius')],
+ [false, t('None')],
Review Comment:
@hexcafe `null` [is a valid
value](https://github.com/search?q=repo%3Aapache%2Fsuperset++%5Bnull%2C+t%28%27None%27%29%5D%2C&type=code)
for the select control. If you prefer to use `false`, then you need to change
the Typescript definition accordingly as it's allowing `undefined`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
