hexcafe commented on code in PR #28597:
URL: https://github.com/apache/superset/pull/28597#discussion_r1608294870
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx:
##########
@@ -87,6 +88,23 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'roseType',
+ config: {
+ type: 'SelectControl',
+ label: t('Rose Type'),
+ default: roseType,
+ renderTrigger: true,
+ choices: [
+ ['area', t('Area')],
+ ['radius', t('Radius')],
+ [false, t('None')],
Review Comment:
I think it's better to keep the value as false; otherwise, the select
control will not behave correctly, and we will never get a chance to choose the
None option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
