hainenber commented on code in PR #29118:
URL: https://github.com/apache/superset/pull/29118#discussion_r1638403719
##########
superset-frontend/src/pages/SavedQueryList/SavedQueryList.test.jsx:
##########
@@ -302,9 +302,13 @@ describe('RTL', () => {
userEvent.click(bulkSelectButton);
// Grab and click the "toggle all" checkbox to expose export button
- const selectAllCheckbox = screen.getByRole('checkbox', {
- name: /toggle all rows selected/i,
- });
+ const selectAllCheckbox = screen
+ .getAllByRole('checkbox', {
+ name: '',
+ })
+ .filter(
+ checkbox => checkbox.getAttribute('name') === 'header-toggle-all',
+ )[0];
Review Comment:
Yes, for some reasons, the `selectAllCheckbox` is not query-able so I had to
rely on attribute name as last resort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
