hainenber commented on code in PR #29118:
URL: https://github.com/apache/superset/pull/29118#discussion_r1638392223
##########
superset-frontend/package.json:
##########
@@ -67,7 +67,8 @@
"prune": "rm -rf
./{packages,plugins}/*/{lib,esm,tsconfig.tsbuildinfo,package-lock.json}",
"storybook": "cross-env NODE_ENV=development BABEL_ENV=development
storybook dev -p 6006",
"tdd": "cross-env NODE_ENV=test jest --watch",
- "test": "cross-env NODE_ENV=test jest",
+ "test": "cross-env NODE_ENV=test jest --max-workers=50%",
+ "test:ci": "cross-env NODE_ENV=test jest",
Review Comment:
Running `jest test` without setting workers in local machine could render
plenty of your application (browser, IDE, et cetera) to be unresponsive and
even cause some tests to timeout. I think that should be run in CI only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
