michael-s-molina commented on PR #29884: URL: https://github.com/apache/superset/pull/29884#issuecomment-2274284725
@betodealmeida @villebro @hughhhh Could you help me fix the following errors? ``` superset/models/helpers.py:824: error: Argument 1 to "get_rls_filters" of "SupersetSecurityManager" has incompatible type "ExploreMixin"; expected "BaseDatasource" [arg-type] superset/models/helpers.py:834: error: Argument 1 to "get_guest_rls_filters" of "SupersetSecurityManager" has incompatible type "ExploreMixin"; expected "BaseDatasource" [arg-type] ``` This the signature of the methods: ``` def get_rls_filters(self, table: "BaseDatasource") -> list[SqlaQuery]: def get_guest_rls_filters(self, dataset: "BaseDatasource") -> list[GuestTokenRlsRule]: ``` The calls to the security manager methods were introduced by https://github.com/apache/superset/pull/22853 and it seems that we already needed to pass `table` and `dataset` at that time but we never did. Do you know where to get them from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
