betodealmeida commented on PR #29884: URL: https://github.com/apache/superset/pull/29884#issuecomment-2291718425
For the type error, I think the current `get_sqla_row_level_filters` method should be moved out of `ExploreMixin` and into `BaseDatasource`, since only datasets can have RLS filters associarted with them (while a `Query` can't). We might need to leave a no-op method in the `ExploreMixin`, since I assume when building a chart from a query the method will get called. @hughhhh does this seem right to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
