michael-s-molina commented on code in PR #29884:
URL: https://github.com/apache/superset/pull/29884#discussion_r1723930066
##########
superset/security/manager.py:
##########
@@ -2645,7 +2645,7 @@ def has_guest_access(self, dashboard: "Dashboard") ->
bool:
dashboards = [
r
for r in user.resources
- if r["type"] == GuestTokenResourceType.DASHBOARD.value
+ if r["type"] == GuestTokenResourceType.DASHBOARD
Review Comment:
@betodealmeida @sadpandajoe This have the potential to break current
security checks but it's the correct comparison for the defined type. Let me
know if it's ok or if we should change the type to `str` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
