rusackas opened a new pull request, #30016: URL: https://github.com/apache/superset/pull/30016
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR lists all dashboards and charts affected by the (potential) deletion of a dataset/database. It also does a little cleanup along the way: * modal is now always centered (so it scrolls sensibly) * the "delete" button is now the "Delete" button * Highlights the name of the dataset/database that's getting deleted... this seems important. * Updates the .pot file since some strings are getting tweaked in there. <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before (Dataset deletion): <img width="637" alt="image" src="https://github.com/user-attachments/assets/13aba672-504f-4c3e-ad12-be375adbd151";> After (Dataset deletion): <img width="652" alt="Screenshot 2024-08-26 at 9 49 07 AM" src="https://github.com/user-attachments/assets/45b496e5-5d4e-4fe4-a834-aa8a96de27bc";> Before (Database deletion) <img width="648" alt="Screenshot 2024-08-26 at 10 11 52 AM" src="https://github.com/user-attachments/assets/fdf927b4-1507-4d88-9486-7457c8498d1a";> After (Database deletion): <img width="637" alt="image" src="https://github.com/user-attachments/assets/7cdfb57f-94a4-4ed7-a480-23e2add1cdac";> <img width="626" alt="image" src="https://github.com/user-attachments/assets/9659069e-1f4d-4467-8305-498ec1ccfc93";> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
