rusackas commented on PR #30016: URL: https://github.com/apache/superset/pull/30016#issuecomment-2313562224
> Some considerations if we actually want to list all the names: > > * We would probably need a search given that it will be hard to find any chart among thousands I'm merely displaying the list that's already data the component has access to. I don't particularly want to go crazy with functionality here. If we need to add full-text fuzzy searching, or a new API for this, I'm open to discussing an additional PR, but I'd say it's out of scope for the moment. > * Users should not scroll to fill the input or click on Cancel or Delete This _is_ possible for the button, as you can lock the modal's footer in place and scroll the contents. However, that footer would be disabled until the user scrolls down anyway to fill the input. We might be able to put the input IN the footer, but that's a weird new pattern to introduce. > * What about other assets types such as Alerts, Saved Queries that will also be impacted? Alerts are not in the scope of the current data AFAIK. I could list the Saved Queries on the database modal if interested, but that seemed of less utility (including the links to them). Is the scrolling the real problem here? I'll just limit the results to fit on a sensible screen. I was just looking for a quick improvement over a modal where you a user has _no idea_ what they're breaking. Another possibility was to just use tooltips where the numbers are, but with a long list, that'd be even more painful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
