rusackas commented on code in PR #30016:
URL: https://github.com/apache/superset/pull/30016#discussion_r1733536319
##########
superset-frontend/src/pages/DatabaseList/DatabaseList.test.jsx:
##########
@@ -164,14 +164,7 @@ describe('Admin DatabaseList', () => {
});
await waitForComponentToPaint(wrapper);
- expect(wrapper.find(DeleteModal).props().description)
- .toMatchInlineSnapshot(`
- <React.Fragment>
- <p>
- The database db 0 is linked to 0 charts that appear on 0 dashboards
and users have 0 SQL Lab tabs using this database open. Are you sure you want
to continue? Deleting the database will break those objects.
- </p>
- </React.Fragment>
- `);
+ expect(wrapper.find(DeleteModal).props().description).toMatchSnapshot();
Review Comment:
InlineSnapshots are no longer supported by Jest. A few changed files in this
PR allow us to use regular snapshots, which remain supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
