DiggidyDave commented on a change in pull request #7391: feat: see Presto row
and array data types
URL:
https://github.com/apache/incubator-superset/pull/7391#discussion_r279113170
##########
File path: superset/db_engine_specs.py
##########
@@ -804,6 +809,21 @@ class PrestoEngineSpec(BaseEngineSpec):
date_add('day', 1, CAST({col} AS TIMESTAMP))))",
}
+ type_map = {
Review comment:
Could this name be made a bit more self-documenting as to what it is mapping
to what? (presto_to_?? ) If presto is the keys, what are the values? (upon
first glance it looks like sqlalchemy abstract types, but then I see that mysql
value there...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
