DiggidyDave commented on a change in pull request #7391: feat: see Presto row
and array data types
URL:
https://github.com/apache/incubator-superset/pull/7391#discussion_r279920200
##########
File path: superset/db_engine_specs.py
##########
@@ -814,6 +822,178 @@ def get_view_names(cls, inspector, schema):
"""
return []
+ @classmethod
+ def _create_column_info(cls, column: RowProxy, name: str, data_type: str)
-> dict:
+ """
+ Create column info object
+ :param column: column object
+ :param name: column name
+ :param data_type: column data type
+ :return: column info object
+ """
+ return {
+ 'name': name,
+ 'type': data_type,
+ # newer Presto no longer includes this column
+ 'nullable': getattr(column, 'Null', True),
+ 'default': None,
+ }
+
+ @classmethod
+ def _get_full_name(cls, names: list) -> str:
Review comment:
@john-bodley We merged this earlier than we should have so I opened a new PR
to address feedback in a new commit... then we can merge all of it to master in
one go, with feedback. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
