DiggidyDave commented on a change in pull request #7391: feat: see Presto row
and array data types
URL:
https://github.com/apache/incubator-superset/pull/7391#discussion_r279113507
##########
File path: superset/db_engine_specs.py
##########
@@ -804,6 +809,21 @@ class PrestoEngineSpec(BaseEngineSpec):
date_add('day', 1, CAST({col} AS TIMESTAMP))))",
}
+ type_map = {
+ 'boolean': types.Boolean,
+ 'tinyint': mysql.MSTinyInteger,
Review comment:
`mysql` ... just calling it out as a divergence from the impl agnostic types
that all of the others are using. It feels "leaky".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
