denodo-research-labs commented on PR #29927: URL: https://github.com/apache/superset/pull/29927#issuecomment-2436240907
@villebro found it, our fault. We were only focusing on ruff liking the `denodo.py` file, but what it was actually complaining about was that it needed to reformat 1 line of code in the unit test `test_denodo.py`. Now `pre-install` funs for us with `--all-files`: ``` $ pre-commit run --all-files auto-walrus..............................................................Passed mypy.....................................................................Passed pip-compile-multi verify.................................................Passed check docstring is first.................................................Passed check for added large files..............................................Passed check yaml...............................................................Passed debug statements (python)................................................Passed fix end of files.........................................................Passed trim trailing whitespace.................................................Passed prettier.................................................................Passed Blacklist................................................................Passed Helm Docs................................................................Passed ruff.....................................................................Passed ruff-format..............................................................Passed pylint...................................................................Passed ``` Sorry for all the fuss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
