denodo-research-labs commented on PR #29927:
URL: https://github.com/apache/superset/pull/29927#issuecomment-2435803502

   Thanks @villebro 
   
   Isn't this the error that is being reported by the linter?
   
   ```
    ************* Module superset.db_engine_specs.denodo
   superset/db_engine_specs/denodo.py:28:0: R0903: Too few public methods (0/2) 
(too-few-public-methods)
   ```
   
   But there's not much that can be done about that in an implementation of a 
DB Engine Spec... it is basically a class only overwriting those attributes / 
methods that need to be overwritten. Perhaps we are missing anything else here?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to