denodo-research-labs commented on PR #29927: URL: https://github.com/apache/superset/pull/29927#issuecomment-2436070786
We did that, but everything looks fine on our end: ``` $ git status On branch denodo/master/db_engine_spec Your branch is up to date with 'origin/denodo/master/db_engine_spec'. $ pre-commit run --files superset/db_engine_specs/denodo.py auto-walrus..............................................................Passed mypy.....................................................................Passed pip-compile-multi verify.............................(no files to check)Skipped check docstring is first.................................................Passed check for added large files..............................................Passed check yaml...........................................(no files to check)Skipped debug statements (python)................................................Passed fix end of files.........................................................Passed trim trailing whitespace.................................................Passed prettier.............................................(no files to check)Skipped Blacklist................................................................Passed Helm Docs............................................(no files to check)Skipped ruff.....................................................................Passed ruff-format..............................................................Passed pylint...................................................................Passed ``` Unfortunately the GitHub task does not give much info, only that ruff is still not happy: ``` ruff.....................................................................Failed - hook id: ruff - files were modified by this hook Found 1 error (1 fixed, 0 remaining). ruff-format..............................................................Failed - hook id: ruff-format - files were modified by this hook 2 files reformatted, 1427 files left unchanged pylint...................................................................Passed ``` But ruff says everything is alright: ``` $ ruff check superset/db_engine_specs/denodo.py All checks passed! ``` Any pointers on how to find out what is happening? ruff version is 0.7.1, pylint 3.3.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
