asher-lab commented on code in PR #30833:
URL: https://github.com/apache/superset/pull/30833#discussion_r1852634923
##########
superset/commands/export/assets.py:
##########
@@ -50,15 +51,17 @@ def run(self) -> Iterator[tuple[str, Callable[[], str]]]:
ExportDatabasesCommand,
ExportDatasetsCommand,
ExportChartsCommand,
+ ExportTagsCommand,
ExportDashboardsCommand,
ExportSavedQueriesCommand,
]
for command in commands:
- ids = [model.id for model in command.dao.find_all()]
- for file_name, file_content in command(ids,
export_related=False).run():
- if file_name not in seen:
- yield file_name, file_content
- seen.add(file_name)
+ if hasattr(command, "dao"):
Review Comment:
My first thought was since it is export I "think" I should add it in the
Assets commands, but no ExportTagsCommand does not use dao at all. We have
removed it in the `commands`. Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
