Vitor-Avila commented on code in PR #30833:
URL: https://github.com/apache/superset/pull/30833#discussion_r1868344821
##########
superset/commands/chart/export.py:
##########
@@ -85,3 +102,12 @@ def _export(
if model.table and export_related:
yield from ExportDatasetsCommand([model.table.id]).run()
+
+ # Check if the calling class is ExportDashboardCommands
+ if (
+ export_related
+ and ExportChartsCommand._include_tags
+ and feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM")
+ ):
+ chart_id = model.id
+ yield from ExportTagsCommand().export(chart_ids=[chart_id])
Review Comment:
I think this logic is in place to prevent calling
`ExportTagsCommand.export()` multiple times. It seems that if it's a dashboard
export, then we don't export tags at the chart export level, and then at the
dashboard level:
``` python
ExportTagsCommand.export( dashboard_ids=dashboard_ids, chart_ids=chart_ids )
```
When exporting charts only, then we export tags at the chart level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
