Vitor-Avila commented on code in PR #30833:
URL: https://github.com/apache/superset/pull/30833#discussion_r1868396641
##########
superset/commands/database/importers/v1/__init__.py:
##########
@@ -42,7 +42,11 @@ class ImportDatabasesCommand(ImportModelsCommand):
import_error = DatabaseImportError
@staticmethod
- def _import(configs: dict[str, Any], overwrite: bool = False) -> None:
+ def _import(
+ configs: dict[str, Any],
+ overwrite: bool = False,
+ contents: Optional[dict[str, Any]] = None,
Review Comment:
You can do `from __future__ import annotations` in this file as well so that
you don't have to use `Optional`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
