mistercrunch commented on code in PR #31590:
URL: https://github.com/apache/superset/pull/31590#discussion_r1927758335
##########
.pre-commit-config.yaml:
##########
@@ -68,6 +60,14 @@ repos:
- [email protected]
args: ["--ignore-path=./superset-frontend/.prettierignore"]
files: "superset-frontend"
+ - repo: local
Review Comment:
Not directly related to PR, but makes more sense to run prettier first as
it's in "fix" more and will often silence double-error-logging between itself
and eslint.
##########
.pre-commit-config.yaml:
##########
@@ -68,6 +60,14 @@ repos:
- [email protected]
args: ["--ignore-path=./superset-frontend/.prettierignore"]
files: "superset-frontend"
+ - repo: local
Review Comment:
Not directly related to PR, but makes more sense to run prettier first as
it's in "fix" mode and will often silence double-error-logging between itself
and eslint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
