mistercrunch commented on code in PR #31590:
URL: https://github.com/apache/superset/pull/31590#discussion_r1930888427
##########
superset-frontend/packages/superset-ui-chart-controls/src/components/ColumnTypeLabel/ColumnTypeLabel.tsx:
##########
@@ -37,9 +37,9 @@ const TypeIconWrapper = styled.div`
display: flex;
justify-content: center;
align-items: center;
- width: ${theme.gridUnit * 6}px;
- height: ${theme.gridUnit * 6}px;
- margin-right: ${theme.gridUnit}px;
+ width: ${theme.sizeUnit * 6}px;
+ height: ${theme.sizeUnit * 6}px;
Review Comment:
Right, for now `sizeUnit === gridUnit === 4`, so just aligning with AntD's
naming here. I believe most padding/margin are a factor of this (or arguably
should be if they aren't). Guessing the `compactAlgorithm()` in AntD mostly
just scales down this one token and things like font sizes down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
