mistercrunch commented on code in PR #31590:
URL: https://github.com/apache/superset/pull/31590#discussion_r1929152005
##########
superset-frontend/packages/generator-superset/generators/plugin-chart/templates/src/MyChart.erb:
##########
@@ -25,29 +25,14 @@ import { <%= packageLabel %>Props, <%= packageLabel
%>StylesProps } from './type
// Theming variables are provided for your use via a ThemeProvider
// imported from @superset-ui/core. For variables available, please visit
-//
https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-core/src/style/index.ts
+//
https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-core/src/theme/index.ts
const Styles = styled.div<<%= packageLabel %>StylesProps>`
- background-color: ${({ theme }) => theme.colors.secondary.light2};
+ background-color: ${({ theme }) => theme.colors.primary.light2};
padding: ${({ theme }) => theme.gridUnit * 4}px;
border-radius: ${({ theme }) => theme.gridUnit * 2}px;
height: ${({ height }) => height}px;
width: ${({ width }) => width}px;
-
Review Comment:
removing this from plugin template as really "you should use CSS minimally
in your plugins"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
