Vitor-Avila commented on PR #32585: URL: https://github.com/apache/superset/pull/32585#issuecomment-2714130883
This is super cool! In regards to: > There is a minor API change in this PR: Previously, we followed Slack's [conversations.list](https://api.slack.com/methods/conversations.list) convention, where empty an types param means that only public channels are returned. After this PR we will return all channel types when types is empty or null. To me that feels more logical, but if people feel we should stick to previous approach I'm OK with changing this. That makes sense to me (if you're not including a filter, you're expecting to get all data), but I'm not super familiar with all rules for API changes, so I'd like to get @eschutho's thoughts here. Would this be considered a breaking change? While it's an API change, this API endpoint is mostly used by the bot (I can't think of a reason someone would interact with this API directly). Regardless, I believe that doesn't hold us from merging, but curious if there should be mention of this in the `UPDATING.md` file and also if we can include it in the next OSS release version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
