Usiel commented on code in PR #32585:
URL: https://github.com/apache/superset/pull/32585#discussion_r1990501785
##########
superset/utils/slack.py:
##########
@@ -71,11 +71,12 @@ def get_channels(limit: int, extra_params: dict[str, Any])
-> list[SlackChannelS
client = get_slack_client()
channel_schema = SlackChannelSchema()
channels: list[SlackChannelSchema] = []
+ extra_params = {"types": ",".join(SlackChannelTypes)}
cursor = None
while True:
response = client.conversations_list(
- limit=limit, cursor=cursor, exclude_archived=True, **extra_params
+ limit=999, cursor=cursor, exclude_archived=True, **extra_params
Review Comment:
If we see a need we could add paging to our `/slack_channels` endpoint (and
`get_channels_with_search(...)`). I don't know about that though, our only
usage is to get all channels to give the user a choice for the report
notification setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
