Usiel commented on code in PR #32585:
URL: https://github.com/apache/superset/pull/32585#discussion_r1988448497
##########
superset/utils/slack.py:
##########
@@ -99,18 +99,25 @@ def get_channels_with_search(
all channels and filter them ourselves
This will search by slack name or id
"""
- extra_params = {}
- extra_params["types"] = ",".join(types) if types else None
try:
channels = get_channels(
- limit=limit,
- extra_params=extra_params,
force=force,
cache_timeout=86400,
)
except (SlackClientError, SlackApiError) as ex:
raise SupersetException(f"Failed to list channels: {ex}") from ex
+ if types and not len(types) == len(SlackChannelTypes):
+ conditions: list[Callable[[SlackChannelSchema], bool]] = []
Review Comment:
The intention here was to make this more easily pluggable in the future if
we add more types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
