msyavuz commented on code in PR #32514:
URL: https://github.com/apache/superset/pull/32514#discussion_r1999071223
##########
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx:
##########
@@ -544,12 +544,20 @@ describe('AdhocFilterEditPopoverSimpleTabContent Advanced
data Type Test', () =>
);
expect(props.validHandler.lastCall.args[0]).toBe(true);
- const operatorValueField = screen.getByText('1 operator(s)');
+ const operatorValueField = screen.getByRole('combobox', {
+ name: 'Select operator',
+ });
+
+ userEvent.click(operatorValueField);
await act(async () => {
userEvent.type(operatorValueField, '{enter}');
});
- expect(screen.getByText('EQUALS')).toBeInTheDocument();
+ expect(
+ await screen.findByText('Equal to (=)', {
+ selector: '.ant-select-selection-item',
Review Comment:
No, unit tests don't get the antd5 prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
