msyavuz commented on code in PR #32514:
URL: https://github.com/apache/superset/pull/32514#discussion_r1999065225
##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -264,8 +276,12 @@ const Select = forwardRef(
}
return [
SELECT_ALL_VALUE,
- ...selectAllEligible.map(opt => opt.value),
- ] as AntdLabeledValue[];
+ ...selectAllEligible
+ .map(opt => opt.value)
+ .filter(
+ (val): val is RawValue => val !== null && val !== undefined,
Review Comment:
There is a type mismatch between v4 and v5 select value types and option
types that needs reconciling with our implementation. In this case i can remove
the null check but in others mentioned i will try to resolve it in a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
